[WIP] Remove foreman vendor #10342
Draft
[WIP] Remove foreman vendor #10342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
UI
Legacy JS
MariaAga
commented
Oct 9, 2024
Comment on lines
+205
to
+211
| export const visit = url => { | ||
| window.location.href = url; | ||
| }; | ||
|
|
||
| export const reloadPage = () => { | ||
| window.location.reload(); | ||
| }; |
MariaAga
commented
Oct 9, 2024
Comment on lines
-40
to
+42
| <%= javascript_include_tag("/webpack/#{get_webpack_chunk('bundle', 'js')}") %> | ||
| <%= javascript_include_tag("/webpack/#{get_webpack_chunk('reactExports', 'js')}") %> | ||
| <%= javascript_include_tag("/webpack/#{get_webpack_chunk('bundle', 'js')}") %> |
MariaAga
commented
Oct 10, 2024
| @@ -5,7 +5,8 @@ | |||
| "description": "Foreman isn't really a node module, these are just dependencies needed to build the webpack bundle. 'dependencies' are the asset libraries in use and 'devDependencies' are used for the build process.", | |||
| "private": true, | |||
| "engines": { | |||
| "node": ">=14.0.0 <21.0.0" | |||
| "node": ">=14.0.0 <21.0.0", | |||
| "npm": ">=8.0.0" | |||
| }, | |||
| "scripts": { | |||
There was a problem hiding this comment.
look into adding NODE_OPTIONS="--max-old-space-size=8192"
|
In this PR we had to update to npm 8 to get the "overrides" attribute in package.json - "Overrides provide a way to replace a package in your dependency tree with another version, or another package entirely. ". @theforeman/packaging are we ok to update to NPM 8+? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #10345