Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overhaul retry/polling logic #99

Merged
merged 5 commits into from
Sep 14, 2023
Merged

Overhaul retry/polling logic #99

merged 5 commits into from
Sep 14, 2023

Conversation

tristanlabelle
Copy link
Contributor

@tristanlabelle tristanlabelle commented Sep 13, 2023 •
edited
Loading

  • Use wall-clock time for checking against the timeout
  • Return the last value returned by the polling closure and a flag indicating if it was successful
  • Throw the last ElementNotInteractable error out of Element.click()
  • Use polling to wait for WinAppDriver.exe termination (won't work on startup due to Timeout if the WebDriver HTTP endpoint is unreachable #40)

Fixes #61, #96

jeffdav
jeffdav approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@jeffdav jeffdav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Sources/Poll.swift Show resolved Hide resolved
@tristanlabelle tristanlabelle merged commit 34557ae into main Sep 14, 2023
1 check passed
@tristanlabelle tristanlabelle deleted the tristan/poll branch September 14, 2023 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffdav jeffdav jeffdav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should retryUntil throw if it fails?
2 participants
@tristanlabelle @jeffdav