Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor NewSessionRequest and Capabilities to separate WinAppDriver functionality #70

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Refactor NewSessionRequest and Capabilities to separate WinAppDriver functionality #70

merged 1 commit into from
Aug 28, 2023

Conversation

tristanlabelle
Copy link
Contributor

  • Introduce a base Capabilities class from which WinAppDriver's own capabilities extend
  • Refactor the NewSessionRequest to be be generic on the Capabilities struct
  • Exposed the capabilities returned by the WebDriver endpoint on the session

@tristanlabelle tristanlabelle merged commit c3d472e into main Aug 28, 2023
1 check passed
@tristanlabelle tristanlabelle deleted the tristan/refactor-sessionrequest-capabilities branch August 28, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffdav jeffdav jeffdav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tristanlabelle @jeffdav