Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename makePNGScreenshot to screenshot to follow the webdriver naming. #64

Merged
merged 1 commit into from
Aug 16, 2023
Merged

Rename makePNGScreenshot to screenshot to follow the webdriver naming. #64

merged 1 commit into from
Aug 16, 2023
+4 −4

Conversation

tristanlabelle
Copy link
Contributor

Mea culpa since I suggested this name in the first place. Updated the documentation comment instead.

@tristanlabelle
Copy link
Contributor Author

Houston, we have flakiness:

Test Case 'SessionTests.testKeysAndAttributes' started at 2023-08-15 14:00:53.108
D:\a\webdriver-swift\webdriver-swift\Tests\WebDriverTests\SessionTests.swift:60: error: SessionTests.testKeysAndAttributes : XCTAssertEqual failed: ("true") is not equal to ("false") - Element still has keyboard focus

jeffdav
jeffdav approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@jeffdav jeffdav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@tristanlabelle tristanlabelle force-pushed the tristan/rename-makePNGScreenshot2 branch from 5112a9b to e8df280 Compare August 16, 2023 14:38
@tristanlabelle
Copy link
Contributor Author

tristanlabelle commented Aug 16, 2023 •
edited
Loading

Houston, we have another flake :(

Test Case 'NotepadTests.testDismissNewFileDialog' started at 2023-08-16 14:42:18.673
<EXPR>:0: error: NotepadTests.testDismissNewFileDialog : threw error "Error Domain=NSURLErrorDomain Code=-1001 "(null)""

@tristanlabelle
Copy link
Contributor Author

Merging because the failure is unrelated to the change, but filed #66

@tristanlabelle tristanlabelle merged commit de9370e into main Aug 16, 2023
1 check failed
@tristanlabelle tristanlabelle deleted the tristan/rename-makePNGScreenshot2 branch August 16, 2023 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffdav jeffdav jeffdav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tristanlabelle @jeffdav