Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CreateProcessW directly and other cleanup. #51

Merged
merged 3 commits into from
Aug 1, 2023
Merged

Use CreateProcessW directly and other cleanup. #51

merged 3 commits into from
Aug 1, 2023

Conversation

jeffdav
Copy link
Contributor

@jeffdav jeffdav commented Aug 1, 2023

  • Switch from Foundation.Process to calling CreateProcessW directly, with bInheritHandles = false.
  • Remove obvious comments.
  • Fix Status test to teardown the WAD wrapper class thus terminating the process.
  • As a sideeffect, WAD stdout is now written to the console. We can revisit if it gets annoying.

tristanlabelle
tristanlabelle requested changes Aug 1, 2023
View reviewed changes
Sources/WinAppDriver.swift Outdated Show resolved Hide resolved
Sources/WinAppDriver.swift Outdated Show resolved Hide resolved
Sources/WinAppDriver.swift Outdated Show resolved Hide resolved
Sources/WinAppDriver.swift Outdated Show resolved Hide resolved
Sources/WinAppDriver.swift Outdated Show resolved Hide resolved
tristanlabelle
tristanlabelle approved these changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@tristanlabelle tristanlabelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it! 🚢

@jeffdav jeffdav merged commit a029de8 into main Aug 1, 2023
1 check passed
@jeffdav jeffdav deleted the jeff/create-process branch August 1, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tristanlabelle tristanlabelle tristanlabelle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffdav @tristanlabelle