-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add retry logic to findElement. #33
Conversation
(I'm not sure this autolink thing is working.) |
Maybe it's not setup on this particular repo 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The structure of the code is looking great but I think should use a different API shape.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple more comments but I think this is the functionality we want! Nice work
maxRetries
andretryInterval
to session object in case anyone wants to change defaults.withRetry = true
param to all the various publicfindElement
methods.withRetry
without default param to the internalfindElement
method that does the actual work so future overloads don't accidentally forget to pass the value through.private findElement
workhorse tointernal
and unified theElement.findElement
methods to call the single implementation inSession
. The only difference between the two code paths was the eventual URL that got constructed, and this removes a lot of duplicate code.Fixes WIN-496