Cleanup #31
Merged
Cleanup #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jeffdav
commented
Jul 19, 2023
jeffdav
commented
- .gitignore .vscode
- Fix some warnings.
tristanlabelle
approved these changes
Jul 19, 2023
| @@ -5,3 +5,4 @@ xcuserdata/ | |||
| DerivedData/ | |||
| .swiftpm/ | |||
| .netrc | |||
| .vscode/ | |||
There was a problem hiding this comment.
I think that's right but FYI we've had discussions on this in different repos because some of the files in there can be useful to share like tasks.json.
| @@ -12,8 +12,8 @@ extension WinAppDriver { | |||
| let args = appArguments?.joined(separator: " ") | |||
|
|
|||
| print("Starting: \(app)") | |||
There was a problem hiding this comment.
If you want to remove the prints even, that's cool with me. I don't think they should be in the library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.