Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Match error type name to filename #160

Merged
merged 3 commits into from
Oct 26, 2024
Merged

Match error type name to filename #160

merged 3 commits into from
Oct 26, 2024

Conversation

tristanlabelle
Copy link
Contributor

The filename had the intended name, following other selenium bindings like https://www.selenium.dev/selenium/docs/api/dotnet/OpenQA.Selenium.NoSuchElementException.html

@tristanlabelle tristanlabelle requested review from jeffdav and a team October 25, 2024 21:03
jeffdav
jeffdav approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@jeffdav jeffdav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tristanlabelle tristanlabelle merged commit 49df0ed into main Oct 26, 2024
4 checks passed
@tristanlabelle tristanlabelle deleted the tristan/rename-NoSuchElementError branch October 26, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffdav jeffdav jeffdav approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tristanlabelle @jeffdav