Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce ElementLocator to replace findElement overloads #155

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Introduce ElementLocator to replace findElement overloads #155

merged 1 commit into from
Sep 24, 2024

Conversation

tristanlabelle
Copy link
Contributor

This brings a few improvements:

  • Less code duplication
  • Separation of accessibility id support in the WinAppDriver module
  • Extensibility to other WebDriver backends
  • Easier to implement higher-level functions like expectElement discussed elsewhere.

jeffdav
jeffdav approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@jeffdav jeffdav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

Sources/WebDriver/ElementLocator.swift Show resolved Hide resolved
@tristanlabelle tristanlabelle merged commit f578048 into thebrowsercompany:main Sep 24, 2024
2 checks passed
@tristanlabelle tristanlabelle deleted the ElementLocator branch September 24, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinocher-bc vinocher-bc vinocher-bc left review comments

@jeffdav jeffdav jeffdav approved these changes

@z2oh z2oh Awaiting requested review from z2oh

@stevenbrix stevenbrix Awaiting requested review from stevenbrix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tristanlabelle @jeffdav @vinocher-bc