Leverage WebDriver built-in implicit wait #153
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been emulating implicit wait functionality by repeated requests when webdriver offers it as a built-in mechanism. Using the built-in mechanism when available has the advantage of making logs less verbose. This change preserves the repeated request emulation mechanism as a fallback.
This change aligns better with web driver concepts. We use "implicit wait timeout" instead of "default retry timeout", and make it only apply to
findElement
, introducing a separate "implicit interaction retry timeout" for interactions (which is not a webdriver protocol built-in functionality). The implicit wait timeout now defaults to 0 seconds, as per spec.Individual operations still offer to specify a wait timeout, and this is implemented by temporarily changing the implicit wait timeout, since that is the only mechanism offered by webdriver.