-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split swift-toolchain.yml triggers into seperate workflows #159
Conversation
5bdc34b
to
ea5a94a
Compare
Happy to upstream the changes to the workflow inputs to compnerd/swift-build. Still sending this for review in the meantime so I can get feedback while the tests run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea!
Upstreamed most of the changes to swift-toolchain.yml and will rebase once compnerd/swift-build#747 is merged. |
f5d3554
to
b1abe21
Compare
This PR is failing to package swift-inspect on cirun because of an if-statement. This will be fixed by compnerd/swift-build#749 |
Update, this change is g2g, just waiting on the base swift-toolchain.yml build to turn green. @z2oh is currently working to resolve. |
3df0101
to
e9afb34
Compare
This PR refactors
swift-toolchain.yml
so that it has no automated triggers. Instead it is only run via one of:workflow_call
workflow_dispatch
.This PR also adds three new workflows that each include a
vars.USE_CIRUN
kill switch:swift-toolchain.yml
with GitHub images onpull_request
swift-toolchain.yml
with Cirun images onpull_request
swift-toolchain.yml
every 6 hours with Azure images onschedule
Separate workflows must be used for the pull-request* workflows instead of one parent workflow that uses GitHub and Cirun images via a
matrix
. This is because the child workflows called from the parent would upload artifacts with identical names, and race. The first uploader wins while the second fails. It is easier to handle this using separate workflow files than it is to - for example - namespace the uploads using a string prefix, inside swift-toolchain.ymlswft-toolchain.yml is also updated with these inputs:
default_runner
compiler_runner
publish_artifacts