Update sentry-native to 0.7.0 release to pickup upstream fix #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntry#926) ...which use a system-provided breakpad (instead of our vendored fork). The problem [here](getsentry#877) was that people who introduce sentry-native via CMake `find_package()` will get insufficient dependencies, which leads to configuration errors in the client CMake project. There are two aspects to this problem: * if the user builds sentry as a shared library, it shouldn't be necessary to specify the dependencies. This can be fixed by defining `breakpad` as a `PRIVATE` dependency. This should also fix the Gentoo issue because it uses sentry as a shared library afaict. * if the user builds sentry as a static library, then we must stay with the `PUBLIC` dependency, but we also need to correctly search for `breakpad`, `libcurl`, and `pthread` in the context of the client project.
sebmarchand
approved these changes
Mar 29, 2024
Good idea! I'll send a PSA once I am merging the change to update our Nuget package in the Arc repo to pickup this new update. |
compnerd
approved these changes
Mar 29, 2024
hjyamauchi
approved these changes
Mar 29, 2024
tristanlabelle
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge updates the sentry-native downstream repo to pickup the changes from the 0.7.0 release (https://github.com/getsentry/sentry-native/releases/tag/0.7.0) .
This is needed to pickup this windows include change:
getsentry#935
to fix the build of Swift-sentry (DEVIN-1050).