Add plumbing for getting crashpad_handler's IPC pipe name #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebmarchand
approved these changes
Apr 29, 2024
sgraham
added a commit
to thebrowsercompany/swift-sentry
that referenced
this pull request
Apr 30, 2024
After crashpad_handler has started, grab the endpoint of the pipe server that crashpad_handler is running, and stash it in an environment variable. This method, and the name of envvar matches Chromium https://source.chromium.org/search?q=CHROME_CRASHPAD%20case:yes&sq=&ss=chromium which will allow the child process registration to work in the same way, and let the environment variable through the sandbox to child processes which otherwise have no environment. Added to sentry-native here: thebrowsercompany/sentry-native#10. Testing: manual via System Informer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow a child process to connect to the pipe server rather than starting its own crashpad_handler.