Bugfix: ask unload when mobile and message visible

the-djmaze · Mar 20, 2023 · 45be0d7 · 45be0d7
1 parent 470da2e
commit 45be0d7
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 7 deletions.
diff --git a/dev/App/User.js b/dev/App/User.js
@@ -183,7 +183,7 @@ export class AppUser extends AbstractApp {
 		super.bootstart();
 
 		addEventListener('beforeunload', event => {
-			if (arePopupsVisible() || (!SettingsUserStore.layout() && MessageUserStore.message())) {
+			if (arePopupsVisible() || (!SettingsUserStore.usePreviewPane() && MessageUserStore.message())) {
 				event.preventDefault();
 				return event.returnValue = i18n('POPUPS_ASK/EXIT_ARE_YOU_SURE');
 			}

diff --git a/dev/Stores/User/Settings.js b/dev/Stores/User/Settings.js
@@ -50,10 +50,10 @@ export const SettingsUserStore = new class {
 
 		self.init();
 
-		self.usePreviewPane = koComputable(() => self.layout() && !ThemeStore.isMobile());
+		self.usePreviewPane = koComputable(() => ThemeStore.isMobile() ? 0 : self.layout());
 
 		const toggleLayout = () => {
-			const value = ThemeStore.isMobile() ? 0 : self.layout();
+			const value = self.usePreviewPane();
 			$htmlCL.toggle('sm-msgView-side', Layout.SidePreview === value);
 			$htmlCL.toggle('sm-msgView-bottom', Layout.BottomPreview === value);
 			fireEvent('rl-layout', value);

diff --git a/dev/View/User/MailBox/MessageList.js b/dev/View/User/MailBox/MessageList.js
@@ -566,11 +566,9 @@ export class MailMessageList extends AbstractViewRight {
 			// initMailboxLayoutResizer
 			const top = dom.querySelector('.messageList'),
 				fToggle = () => {
-					let layout = SettingsUserStore.layout();
+					let layout = SettingsUserStore.usePreviewPane();
 					setLayoutResizer(top, ClientSideKeyNameMessageListSize,
-						(ThemeStore.isMobile() || !layout)
-							? 0
-							: (Layout.SidePreview === layout ? 'Width' : 'Height')
+						layout ? (Layout.SidePreview === layout ? 'Width' : 'Height') : 0
 					);
 				};
 			if (top) {