Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deno upgraded to version 2 and express-deno added #7847

Merged
merged 3 commits into from
Oct 12, 2024

Conversation

zahidcakici
Copy link
Contributor

Deno upgraded to version 2.0 and with the new feature npm packages are now available like express.js.

express-deno added to the project

@zahidcakici
Copy link
Contributor Author

zahidcakici commented Oct 11, 2024

For the failing test: opine framework cut its support (last release 16-04-2023) and since it is an express port, recommends using express npm package with deno 2 just as the PR I opened.

We might consider removing it.
cc: @waghanza

Screenshot 2024-10-11 at 16 07 02

@waghanza
Copy link
Collaborator

waghanza commented Oct 11, 2024

Could you ping the author of express-deno author, or any core contributor @zahidcakici ?

We should remove opine @cmorten

javascript/config.yaml Outdated Show resolved Hide resolved
@waghanza
Copy link
Collaborator

I think you could remove it here @zahidcakici

@cmorten
Copy link

cmorten commented Oct 11, 2024

Could you ping the author of express-deno author, or any core contributor @zahidcakici ?

We should remove opine @cmorten

Hi 👋

Yes now Deno supports Express OOTB I don’t intend to maintain or promote Opine anymore, feel free to remove for v2

Copy link
Contributor Author

@zahidcakici zahidcakici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, after the failing task again I'm pretty sure we need that flag

javascript/config.yaml Outdated Show resolved Hide resolved
@waghanza waghanza enabled auto-merge (squash) October 12, 2024 07:44
@waghanza waghanza merged commit 9fbc2a4 into the-benchmarker:master Oct 12, 2024
54 checks passed
@waghanza
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants