Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify code and config #7840

Merged
merged 14 commits into from
Oct 7, 2024
Merged

Simplify code and config #7840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
55c50b0
Refactor controller to use functional routing
Sep 24, 2024
044f195
Refactor route definitions in BenchmarkRouter
Sep 24, 2024
7a6b283
Rename BenchmarkRouter class to BenchmarkController
Sep 24, 2024
f7b38cb
Rename package from router to controller
Sep 24, 2024
9f7dc7b
Merge branch 'the-benchmarker:master' into master
nathphon Oct 1, 2024
cb98516
Enable caching and optimize Netty server configuration
Oct 1, 2024
fc92cfa
Remove DATE and SERVER headers from responses
Oct 1, 2024
6ff1db8
Simplify response headers handling for cache control
Oct 1, 2024
e0d9b9c
Remove HttpHeaders.CONNECTION and tweak server settings
Oct 1, 2024
a6acf83
Remove cache control from BenchmarkController
Oct 2, 2024
dd2cebe
Refactor imports in BenchmarkController
Oct 2, 2024
c49b5ad
Merge branch 'the-benchmarker:master' into master
nathphon Oct 7, 2024
b777232
Simplify HTTP responses and update application properties
Oct 7, 2024
3a8e806
Disable Netty leak detection and header validation
Oct 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 4 additions & 19 deletions java/spring-webflux/src/main/java/framework/benchmark/controller/BenchmarkController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,28 +13,13 @@
@Component
public class BenchmarkController {

private static final Mono<ServerResponse> EMPTY_RESPONSE = ServerResponse.ok()
.contentType(MediaType.TEXT_PLAIN)
.headers(h -> {
h.remove(HttpHeaders.SERVER);
h.remove(HttpHeaders.CONNECTION);
})
.build().share();


@Bean
public RouterFunction<ServerResponse> routes() {
return route()
.GET("/", request -> EMPTY_RESPONSE)
.GET("/user/{id}", request -> ServerResponse.ok()
.contentType(MediaType.TEXT_PLAIN)
.headers(h -> {
h.remove(HttpHeaders.SERVER);
h.remove(HttpHeaders.CONNECTION);
})
.bodyValue(request.pathVariable("id")))
.POST("/user", request -> EMPTY_RESPONSE)
.GET("/", request -> ServerResponse.ok().bodyValue(""))
.GET("/user/{id}", request -> ServerResponse.ok().bodyValue(request.pathVariable("id")))
.POST("/user", request -> ServerResponse.ok().bodyValue(""))
.build();
}

}
}
18 changes: 3 additions & 15 deletions java/spring-webflux/src/main/resources/application.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,6 @@
server.port=3000
spring.main.banner-mode=off
server.error.whitelabel.enabled=false
logging.level.root=WARN
server.http2.enabled=true
spring.threads.virtual.enabled=true
spring.main.lazy-initialization=true
spring.main.keep-alive=true
server.netty.validate-headers=false
server.netty.connection-timeout=5s
server.netty.idle-timeout=30s
server.netty.h2c-max-content-length=1MB
server.netty.initial-buffer-size=64KB
server.netty.max-initial-line-length=8KB
server.netty.max-keep-alive-requests=1000
logging.level.root=ERROR
spring.netty.leak-detection=disabled
server.compression.min-response-size=1KB
server.compression.enabled=true
spring.reactor.netty.shutdown-quiet-period=0s
server.netty.validate-headers=false
Loading