Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

engine: mitigates memory leak #1535

Merged
merged 1 commit into from
Jun 26, 2023
Merged

engine: mitigates memory leak #1535

merged 1 commit into from
Jun 26, 2023

Conversation

inkeliz
Copy link
Contributor

@inkeliz inkeliz commented Jun 25, 2023

Previouly, each compiledFuction retain one pointer of compiledModule.

@inkeliz
Copy link
Contributor Author

inkeliz commented Jun 25, 2023 •
edited
Loading

That might not be the "perfect solution", I'm justing sending here to make easier to test. :)
Related to #1534

@inkeliz
engine: fix memory leak
7955c3e 
Previouly, each compiledFuction retain one pointer of compiledModule.

Signed-off-by: inkeliz <[email protected]>
@inkeliz inkeliz changed the title engine: fix memory leak engine: mitigates memory leak Jun 25, 2023
mathetake
mathetake reviewed Jun 25, 2023
View reviewed changes
Copy link
Member

@mathetake mathetake left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change makes sense and actually fixes a bug introduced in #1377 which is a root cause to #1534. Thank @inkeliz for tracking down!

edited: re-read the thread in #1534 and realized that it is actually weird on why this is solving the issue... 🤷

internal/engine/compiler/engine.go Show resolved Hide resolved
codefromthecrypt
codefromthecrypt approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

@codefromthecrypt codefromthecrypt merged commit 451a1b6 into tetratelabs:main Jun 26, 2023
@abraithwaite abraithwaite mentioned this pull request Jun 27, 2023
Closed
@ncruces ncruces mentioned this pull request Aug 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathetake mathetake mathetake left review comments

@codefromthecrypt codefromthecrypt codefromthecrypt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@inkeliz @codefromthecrypt @mathetake