Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes broken and untested Linux package signing #395

Merged
merged 1 commit into from
Oct 10, 2021

Conversation

codefromthecrypt
Copy link
Contributor

This didn't work at all. It was hidden because variables weren't exported, so they didn't reach nfpm.

-       @$(go) run $(nfpm) pkg -f $1 --packager $2 --target $3
+       @# $(go:go=) removes the trailing 'go', so we can insert package signing variables
+       @$(go:go=) NFPM_KEYFILE=$(NFPM_KEYFILE) NFPM_KEYID=$(NFPM_KEYID) NFPM_PASSPHRASE=$(NFPM_PASSPHRASE) \
+       go run $(nfpm) pkg -f $1 --packager $2 --target $3

We also could have noticed this if our test scripts verified signatures, which they didn't!

@codefromthecrypt
Copy link
Contributor Author

#396 will eventually re-add this

@codefromthecrypt codefromthecrypt merged commit eca33d6 into master Oct 10, 2021
@codefromthecrypt codefromthecrypt deleted the remove-busted-signatures branch October 10, 2021 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant