Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: loader stomping context from other loaders #108

Merged
merged 1 commit into from
Mar 16, 2024

Conversation

JakobJingleheimer
Copy link
Contributor

@JakobJingleheimer JakobJingleheimer commented Mar 14, 2024

@JakobJingleheimer
Copy link
Contributor Author

Sorry, for the noise: I tried to rename the branch to something more useful. I swear I've done that before without GitHub flipping the table.

@giltayar giltayar merged commit fdf9156 into testdouble:main Mar 16, 2024
6 checks passed
@giltayar
Copy link
Contributor

I'm missing a test that checks this, but I'll try and add one now.

@JakobJingleheimer
Copy link
Contributor Author

You're welcome to use the tests from jakobjingleheimer/nodejs-loaders. Those loaders all work with testdouble. I can add some here if you'd like (they use the same node:assert & node:test)

@searls
Copy link
Member

searls commented Mar 21, 2024

Landed in v0.9.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replaceEsm breaks in node20 when other loaders are used
3 participants