Paginate through users #51
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there are/have been over 1000 users in an organization, the eligible_user_ids method in loads_slack_channel_members would only retrieve the first 1000. This change adds a method to follow any pagination cursors and combine user pages together to ensure we have a complete user list to compare to when intersecting with the channel member list. This change also adds a limit of 200 for user retrievable, as recommended by Slack's API guide.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If there are/have been over 1000 users in an organization, the
eligible_user_ids method in loads_slack_channel_members would only
retrieve the first 1000.
This means that any member of the channel that is not included in the
first 1000 users of list_users will not be included for matching.
Solution
This change adds a method to follow any pagination cursors and combine
user pages together to ensure we have a complete user list to compare
to when intersecting with the channel member list.
This change also adds a limit of 200 for user retrievable, as
recommended by Slack's API guide.