Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paginate through slack channels #38

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Commits on Feb 21, 2022

  1. Paginate through slack channels

    If there are over 1000 slack channels in an organization, which is
    entirely possible with the ability to archive channels, the call method
    in loads_slack_channels would only retrieve the first 1000.
    
    This change adds a method to follow any pagination cursors and combine
    channel list pages together to ensure we have a complete channel list.
    
    This change also makes use of the exclude_archived argument for
    conversations_list which will (on Slack's side) throw out any archived
    channels. A snippet to keep in mind from Slack's docs:
    
    https://api.slack.com/methods/conversations.list
    "When paginating, any filters used in the request are applied after
    retrieving a virtual page's limit. For example. using
    exclude_archived=true when limit=20 on a virtual page that would contain
    15 archived channels will return you the virtual page with only 5
    results. Additional results are available from the next cursor
    valuePaginate through slack channels."
    sej3506 committed Feb 21, 2022
    Configuration menu
    Copy the full SHA
    42780e6 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2022

  1. Add keyword args, update spec, and bug

    Changing get_paged_chanels to take keyword args.
    Updating the loads_slack_channels spec for testing pagination to include
    the pagination cursor.
    Including types when calling get_paged_channels (bug fix)
    sej3506 committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    cee64d2 View commit details
    Browse the repository at this point in the history