-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Fix tests, remove EOL OSes, fix Ruby 3.4 compatibility warnings #421
base: main
Are you sure you want to change the base?
Changes from 11 commits
355bb2a
9df17f1
0eee013
c2a06f7
c807bee
66a894f
48430e9
b878f08
e275469
3ee6ad5
2004b94
ccc3c94
8ea4e37
5c61930
42ffa29
a84fe35
f8e3b26
e961595
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,3 +19,5 @@ tmp | |
.kitchen.local.yml | ||
Dockerfile | ||
.DS_Store | ||
bin/* | ||
.idea/* |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
FROM centos:7 | ||
FROM oraclelinux:7 | ||
RUN yum clean all | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. in the kitchen-dokken driver we switched to almalinux-9. Should probably do the same here for consistency and future proofing. Then the yum commands can be updated to dnf. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I updated the Dockerfile and got it building successfully, but kitchen-docker complains the container isn't listening for ssh connections. Perhaps I need to change the CMD to run the ssh server? It wasn't obvious to me why it worked with Oracle 7 but not Alma 9. |
||
RUN yum install -y sudo openssh-server openssh-clients which curl htop | ||
RUN ssh-keygen -t rsa -f /etc/ssh/ssh_host_rsa_key | ||
|
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This slug should get you the latest without having to maintain the version here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ended up putting in the two versions separately because both of them showed to still be under active support on the website.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh wait I see what you mean. Specify a "latest v15" in addition to a "specific v15."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leap:15 should always be the latest