Draft: Add basic planar joint support in the urdf parser #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } | ||
|
|
||
| void addLink(tesseract_scene_graph::SceneGraph::UPtr& sg, |
There was a problem hiding this comment.
I would probably have this pass the scenegraph by reference.
|
I been looking at how MoveIt accomplishes this and think it aligns with what we would like to do. In this case add the concepts of variables where a joint can have multiple variables. A good point of reference is the joint model here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Levi and I discussed how to implement this. The better solution would probably be to implement planar joints in the state solver. However, that would touch a lot of things. Instead we decided to get an MVP working by inserting 3 joints for each planar joint in the URDF. They are named
<urdf_name>_<x, y, or yaw>_planar. Then the ROS environment monitor will listen to TF and update these TFs as appropriate