Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ToolPath and ToolPathSegment class #832

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Levi-Armstrong
Copy link
Contributor

@Levi-Armstrong Levi-Armstrong commented Nov 29, 2022

This adds two classes ToolPath and ToolPathSegment. These two classes provided additional information for traceability during filtering operations and integration into tesseract_qt rendering. @marip8 Would you have time to take a look at this PR?

image

@marip8
Copy link
Contributor

marip8 commented Nov 29, 2022

What are you planning to use these for?

@Levi-Armstrong
Copy link
Contributor Author

Primarily for tool path visualization in tesseract_qt and filtering operations in a larger task composer graph which removes unreachable waypoints, small segments and breaking up large segments at configuration flips.

@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Merging #832 (be58dda) into master (015a9eb) will increase coverage by 0.01%.
The diff coverage is 93.10%.

❗ Current head be58dda differs from pull request most recent head ee5325f. Consider uploading reports for the commit ee5325f to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #832      +/-   ##
==========================================
+ Coverage   90.19%   90.20%   +0.01%     
==========================================
  Files         234      238       +4     
  Lines       14127    14185      +58     
==========================================
+ Hits        12742    12796      +54     
- Misses       1385     1389       +4     
Impacted Files Coverage Δ
...ct_common/include/tesseract_common/serialization.h 89.36% <ø> (ø)
...seract_common/include/tesseract_common/tool_path.h 66.66% <66.66%> (ø)
...ommon/include/tesseract_common/tool_path_segment.h 66.66% <66.66%> (ø)
tesseract_common/src/tool_path_segment.cpp 92.85% <92.85%> (ø)
tesseract_common/src/tool_path.cpp 100.00% <100.00%> (ø)

@marip8
Copy link
Contributor

marip8 commented Nov 30, 2022

Primarily for tool path visualization in tesseract_qt and filtering operations in a larger task composer graph which removes unreachable waypoints, small segments and breaking up large segments at configuration flips.

Sounds familiar...

Why not just use a composite instruction of Cartesian waypoints or move instructions instead? Seems like that probably has all the information necessary to do what you're looking for without having to add and maintain a new set of classes

@Levi-Armstrong
Copy link
Contributor Author

Levi-Armstrong commented Nov 30, 2022

Why not just use a composite instruction of Cartesian waypoints or move instructions instead? Seems like that probably has all the information necessary to do what you're looking for without having to add and maintain a new set of classes

Yea, I thought about that but was not sure. It would be good to meet and discuss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants