Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- Fixed build on Windows #320

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

lmartorella
Copy link
Contributor

Description

Fixes show-stopper build on Windows:

> go build ./...
# github.com/teslamotors/vehicle-command/pkg/connector/ble
..\..\pkg\connector\ble\ble.go:161:17: undefined: newDevice

Even if not supported for BLE, building on Windows is still possible for other targets like the tesla-http-proxy. With the proposed basic change the build is unblocked.

Invoking commands that involves BLE will be correctly report the runtime error:

> tesla-control -ble add-key-request public_key.pem owner cloud_key
Error: failed to find a BLE device: Not supported on Windows

Type of change

Please select all options that apply to this change:

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix (non-breaking change which fixes an build issue)
  • Documentation update

Checklist:

Confirm you have completed the following steps:

  • My code follows the style of this project.
  • I have performed a self-review of my code.
  • No need to update the documentation.
  • No need for unit tests.

@sethterashima sethterashima merged commit 2e033ec into teslamotors:main Oct 10, 2024
1 check passed
@sethterashima
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants