Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hardware][Tenstorrent] Modify offline_inference_tt.py to include max_tokens arg #25

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

milank94
Copy link

Modify offline_inference_tt.py to include the following changes:

  • add max_tokens as an input argument for the user to set the desired output length
  • set max_tokens default length to 128
  • change TTFT output stats to per user from batch reporting

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@milank94 milank94 merged commit 18f0e91 into dev Oct 21, 2024
@milank94 milank94 deleted the mkordic/tt_offline_inference branch October 21, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants