Add graph capture validation pass #1195
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derdeljanTT
requested review from
tapspatel,
nsmithtt,
jnie-TT,
kmabeeTT,
AleksKnezevic,
pilkicTT,
sdjordjevicTT,
svuckovicTT,
mtopalovicTT,
rpavlovicTT,
nobradovictt and
jserbedzijaTT
as code owners
tapspatel
reviewed
Nov 7, 2024
| @@ -450,6 +457,7 @@ def _execute(binaries): | |||
| program_index, | |||
| total_inputs[loop], | |||
| total_outputs[loop], | |||
| self["--use-graph-capture"], | |||
There was a problem hiding this comment.
can we add this in trt.runtime.DebugEnv? It seems like this feature is a debug mode feature and the infra is already there to add specific bools like this one
debug_env = ttrt.runtime.DebugEnv.get(
self["--load-kernels-from-disk"], self["--enable-async-ttnn"]
)
tapspatel
reviewed
Nov 7, 2024
| const std::unordered_set<uint32_t> &programInputs, | ||
| const std::unordered_set<uint32_t> &programOutputs, | ||
| ::ttnn::MeshDevice *meshDevice, bool useGraphCapture) { | ||
| if (useGraphCapture) { |
There was a problem hiding this comment.
this would be something like debug::Env::get().useGraphCapture
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a mlir pass which performs graph capture validation of output TTNN graph. By default, this pass is disabled. #1183
fyi @mbezuljTT @s-jovic