-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#0: SFPU UT param sweep: #14422
Open
ncvetkovicTT
wants to merge
2
commits into
main
Choose a base branch
from
ncvetkovic/0-bh-llk_test_coverage_SFPU_param_sweep
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
#0: SFPU UT param sweep: #14422
ncvetkovicTT
wants to merge
2
commits into
main
from
ncvetkovic/0-bh-llk_test_coverage_SFPU_param_sweep
+356
−336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncvetkovicTT
requested review from
abhullar-tt,
pgkeller,
aliuTT,
tt-aho,
tt-dma,
tt-asaigal and
ubcheema
as code owners
October 29, 2024 11:39
ncvetkovicTT
force-pushed
the
ncvetkovic/0-bh-llk_test_coverage_SFPU_param_sweep
branch
from
October 29, 2024 11:39
58ad844
to
d1d9d04
Compare
ncvetkovicTT
force-pushed
the
ncvetkovic/0-bh-llk_test_coverage_SFPU_param_sweep
branch
from
October 29, 2024 18:42
d1d9d04
to
8a57153
Compare
ncvetkovicTT
force-pushed
the
ncvetkovic/0-bh-llk_test_coverage_SFPU_param_sweep
branch
from
November 1, 2024 14:35
ae9cec8
to
6bc2a31
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/1)
ncvetkovicTT
force-pushed
the
ncvetkovic/0-bh-llk_test_coverage_SFPU_param_sweep
branch
3 times, most recently
from
November 7, 2024 22:28
9397144
to
420fd8f
Compare
- in_range [-7.0f, 7.0f] - fp_32_dest_accum_en - shape - from 1x1x1x1 up to 1x1x16x16 - num_tiles - from 1 uo to 256 - data_formats - Bfp4_b, Bfp8_b, Float16_b, Fp32
ncvetkovicTT
force-pushed
the
ncvetkovic/0-bh-llk_test_coverage_SFPU_param_sweep
branch
from
November 8, 2024 10:05
420fd8f
to
fdad715
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
N/A
Problem description
Unit test for SFPU LLK doesn't test the whole domain of the SFPU functions, data format is hardcoded to bfloat16 and input block and the number of tiles are limited. This PR resolves those issues.
What's changed
The SFPU unit test (test_sfpu_compute.cpp) now sweeps over:
Checklist