Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#0: SFPU UT param sweep: #14422

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ncvetkovicTT
Copy link
Contributor

@ncvetkovicTT ncvetkovicTT commented Oct 29, 2024

Ticket

N/A

Problem description

Unit test for SFPU LLK doesn't test the whole domain of the SFPU functions, data format is hardcoded to bfloat16 and input block and the number of tiles are limited. This PR resolves those issues.

What's changed

The SFPU unit test (test_sfpu_compute.cpp) now sweeps over:

  • the whole domain of the SFPU functions - [-7.0f, 7.0f]
  • fp_32_dest_accum_en flag
  • different input block shapes - from 1x1x1x1 up to 1x1x10x10
  • different number of tiles - from 1 up to 100
  • different data formats (currently Float32, Float16_b, Bfp8_b and Bfp4_b for input, and Float32/Float16_b for output)

Checklist

  • Post commit CI passes - #19322
  • Blackhole Post commit (if applicable) - #1509
  • Model regression CI testing passes (if applicable)
  • Device performance regression CI testing passes (if applicable)
  • New/Existing tests provide coverage for changes

@ncvetkovicTT ncvetkovicTT force-pushed the ncvetkovic/0-bh-llk_test_coverage_SFPU_param_sweep branch from 58ad844 to d1d9d04 Compare October 29, 2024 11:39
@ncvetkovicTT ncvetkovicTT force-pushed the ncvetkovic/0-bh-llk_test_coverage_SFPU_param_sweep branch from d1d9d04 to 8a57153 Compare October 29, 2024 18:42
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

@ncvetkovicTT ncvetkovicTT force-pushed the ncvetkovic/0-bh-llk_test_coverage_SFPU_param_sweep branch 3 times, most recently from 9397144 to 420fd8f Compare November 7, 2024 22:28
- in_range [-7.0f, 7.0f]
- fp_32_dest_accum_en
- shape - from 1x1x1x1 up to 1x1x16x16
- num_tiles - from 1 uo to 256
- data_formats - Bfp4_b, Bfp8_b, Float16_b, Fp32
@ncvetkovicTT ncvetkovicTT force-pushed the ncvetkovic/0-bh-llk_test_coverage_SFPU_param_sweep branch from 420fd8f to fdad715 Compare November 8, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant