-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BOUNTY] Add Qwen1.5 0.5B #37
[BOUNTY] Add Qwen1.5 0.5B #37
Conversation
With all these patches, we internally have Qwen1.5 0.5B working on a Grayskull e150 (thanks @JonathanALevine). We're waiting for @marty1885 to test all of this in his e75. Should we convert this out of a draft PR? |
A lot of optimizations will need to be made to speed this model up, stay tuned. I gotta do my uni assignments which are due tonight 😭 |
Great work @JushBJJ @marty1885 @JonathanALevine! Let us know once you get silicon results out of E75 :))) We're working out some internal checking, as soon as we finalize those on our side we're going to complete code reviews and start with PR approvals. Once again great progress and thanks for hunting these bounties! :))) |
@nvukobratTT @milank94 Update :) |
@JushBJJ way to go! As we don't have automated CI setup yet for this project, we'll manually test the model. Before that, there are a few miscellaneous components that should be added in such as update support table, add test case, add license header, etc. You can see a breakdown here: https://github.com/tenstorrent/tt-buda-demos/blob/main/CONTRIBUTING.md#adding-models Mind adding these details in and we'll continue the review process? |
Sure I'll do it too with the Phi 2 bounty as well, let me know if you guys had any issue running it. I raised an issue (tenstorrent/tt-buda#42) because I'm not quite sure how a proper implementation would look like for DynamicCaching so it would be great if anyone in the TT team familiar with it can make a proper fix :) |
Thanks for the update. We'll get someone to review and integrate the work arounds. We can look to package this as an alpha release @staylorTT FYI: @Shubhamsaboo for bounty tracking |
Made some changes:
I also tested on previous transformers versions, seems like v4.42.0 is some magic number??? Any version below that Qwen does not work at all. |
Thanks @JushBJJ . I will have a look. That's good to note. The latest release of Buda is on |
See tenstorrent/tt-buda#42 (comment) I'll rewrite Qwen's file with a custom wrapper/generate forward function |
This should be good now for final review and testing. See tenstorrent/tt-buda#42 (comment) for my comment on disabling DynamicCache on new models |
Any updates on this on TT's side? @milank94 |
Hey @JushBJJ -- we're currently working on integrating all of necessary changes into a new Buda release. This should add the support for this model and the Phi-2, along with some additional features. Once we have that RC ready, we'll do the test and merging of these models. Thanks for the patience. |
Hey @JushBJJ can you switch the target branch to be: mkordic/rc_20240830? |
Done |
Looks great @JushBJJ - can you address the merge conflict around I merged the changes for #117, I think this branch just needs a rebase onto mkordic/rc_20240830. The plan is to merge these two models into a RC branch (mkordic/rc_20240830), that we are using to updated the changes for the next TT-Buda release, then merge into |
@milank94 Rebased it, i normally dont do it so I hope i did it right 😅 |
* Qwen1.5 0.5B pybuda implementation * remove unneeded requirement * Update env vars and compiler configs * remove undefined device_map * Remove misleading and unnecessary environment variables * Refine qwen solution * Rename qwen file * Rename qwen filename and added qwen1.5-chat * Add qwen1.5 test case * Fix typo in pyproject.toml * Disable dynamic caching * Add extra whitespace below model title commment * Fix typo "moadl" to "model"
This PR is with the help of @marty1885 and @JonathanALevine.
Bounty: #20
The following issues need to be addressed:
tvm.relay.expr.Call
Inputs tt-tvm#2aten::triu
OP inputs when inputs are CallNodes [Bug] tt-tvm#3tril
ops with dynamicdiagonal
argument tt-tvm#5Video of it working: https://www.youtube.com/watch?v=Tlb1ElBHqVk
Requirements