Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#22: Fix (shared) memory overfill causing device hang #23

Merged
merged 3 commits into from
May 14, 2024

Conversation

milank94
Copy link
Collaborator

@milank94 milank94 commented May 13, 2024

Modifies the benchmark.py script to only store the input labels and outputs for 1 iteration of the dataset if --loop_count > 1.

This prevents the shared memory from becoming full and causing a device hang.

Addresses #22

@milank94 milank94 linked an issue May 13, 2024 that may be closed by this pull request
@anirudTT anirudTT self-requested a review May 13, 2024 20:36
Copy link
Contributor

@anirudTT anirudTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@milank94 milank94 merged commit b206678 into main May 14, 2024
9 checks passed
@milank94 milank94 deleted the mkordic/fix-loop-count-mem branch May 14, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Shared) memory overfill causing device hang
2 participants