Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply spotless to generated files, exclude c api files #359

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Apply spotless to generated files, exclude c api files #359

wants to merge 5 commits into from

Conversation

rnett
Copy link
Contributor

@rnett rnett commented Jul 30, 2021

Does what it says in the title. I can include the C API files if you want, but most of them (especially the presets) have special formatting by @saudet and I'm not sure if we want to override that.

@rnett
Copy link
Contributor Author

rnett commented Jul 30, 2021 •
edited
Loading

Also, when I run generation locally I get a bunch of new op classes like CacheDatasetV2 that are in ops.pb but don't seem to be generated in master, can anyone reproduce this? Did we at some point not push the new ops?

@rnett
Copy link
Contributor Author

rnett commented Jul 31, 2021

I also added a .gitattributes to set the line endings of most files to LF, since I was running into issues with it w/ the formatter when switching between Windows and Linux. Most of the generation code assumes that anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rnett