Callbacks phase 1 #299
Open
Callbacks phase 1 #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync with master tensorflow on upstream
Merge main branch to local branch
Update after losses merge
Fix Javadoc errors (tensorflow#152)
pull type def
Metrics Phase 1 (tensorflow#180)
Pull latest tensorflow master
Merge with latest
Resync with origin/master
Sync with tensorflow/java master
Sync with Metrics Phase 2
Sync with master
Sync with Regularizers
Craigacp
requested changes
May 6, 2021
tensorflow-framework/src/main/java/org/tensorflow/framework/callbacks/CSVLogger.java
Show resolved
Hide resolved
tensorflow-framework/src/main/java/org/tensorflow/framework/callbacks/CSVLogger.java
Outdated
Show resolved
Hide resolved
tensorflow-framework/src/main/java/org/tensorflow/framework/callbacks/CSVLogger.java
Outdated
Show resolved
Hide resolved
|
|
||
| /** Creates a Callback */ | ||
| protected Callback() { | ||
| this(null); |
There was a problem hiding this comment.
Would it be better to use Collections.emptyMap() here rather than null? Or is it mutated?
There was a problem hiding this comment.
So far none of the subclasses write to it, so we could use emptyMap().
I don't think it is a good idea to leave it null. Also make it final in Callback.
tensorflow-framework/src/main/java/org/tensorflow/framework/callbacks/CSVLogger.java
Show resolved
Hide resolved
tensorflow-framework/src/main/java/org/tensorflow/framework/callbacks/util/ProgressBar.java
Show resolved
Hide resolved
tensorflow-framework/src/main/java/org/tensorflow/framework/callbacks/util/ProgressBar.java
Outdated
Show resolved
Hide resolved
tensorflow-framework/src/test/java/org/tensorflow/framework/callbacks/CSVLoggerTest.java
Outdated
Show resolved
Hide resolved
tensorflow-framework/src/test/java/org/tensorflow/framework/callbacks/CSVLoggerTest.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| @Test | ||
| void onEpochEnd() {} |
|
Mostly small stuff and some tidying in the docs. Otherwise it looks pretty good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first Phase of Callbacks and is just a minimal set to start work on Model.
There is a chicken and egg relationship with Callbacks and Model, so this PR just addresses the first part with integration with Model postponed. Only enough Callbacks to get started with Model are provided for now.
Once model is done, then a 2nd phase PR with full integration with Model will be created.