Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added beginner friendly example of diabetes dataset #93

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

aiwithqasim
Copy link

Worked on PIMA India's Diabetes dataset using TensorFlow's Decision Forest (TF-DF) & compare the result with Decision Tree that I had did previously.

@google-cla
Copy link

google-cla bot commented Apr 8, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@aiwithqasim aiwithqasim closed this Apr 8, 2022
@aiwithqasim aiwithqasim reopened this Apr 8, 2022
@aiwithqasim
Copy link
Author

Signed a Contributor License Agreement (CLA).

@aiwithqasim
Copy link
Author

@googlebot I signed it!

@achoum
Copy link
Collaborator

achoum commented Apr 11, 2022

Hi Qasim,
Thanks for the example. It looks great.

Copy link
Collaborator

@rstz rstz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for putting this together. I've left a few comments to suggest possible improvements

examples/beginner_diabetes.py Outdated Show resolved Hide resolved
examples/beginner_diabetes.py Outdated Show resolved Hide resolved
examples/beginner_diabetes.py Outdated Show resolved Hide resolved
examples/beginner_diabetes.py Outdated Show resolved Hide resolved
examples/README.md Outdated Show resolved Hide resolved
@aiwithqasim
Copy link
Author

@rstz updated according to the suggested possible improvements. Let me know if still need any improvement. You can give me more ideas. I'll be happy to contribute.

@rstz
Copy link
Collaborator

rstz commented Apr 19, 2022

LGTM, Thank you for the revisions. I think we can merge this, and feel free to have a look at GBT models as well.

@aiwithqasim
Copy link
Author

@rstz looking forward to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants