Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed missing proto issue for smart buildings dataset. As discussed with @weide the fix is to: #5675

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed missing proto issue for smart buildings dataset. As discussed with @weide the fix is to: #5675

wants to merge 1 commit into from

Conversation

copybara-service[bot]
Copy link
Contributor

Fixed missing proto issue for smart buildings dataset. As discussed with @weide the fix is to:

  1. Move protos to the dedicated proto directory
  2. Include the generated compiled files using the protoc command

I also created folders in the test data for all years, with a dummy file that will be ignored.

This still needs external testing to verify

@tomvdw
Fixed missing proto issue for smart buildings dataset. As discussed w…
37a3b46 
…ith @weide the fix is to:

1. Move protos to the dedicated proto directory
2. Include the generated compiled files using the protoc command

I also created folders in the test data for all years, with a dummy file that will be ignored.

This still needs external testing to verify

PiperOrigin-RevId: 687238663
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tomvdw