[TEST]: Improvement: Verification of validation response #5741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanChupin
approved these changes
Oct 14, 2024
|
|
||
| } | ||
|
|
||
| static private List<SubFlowValidationDiscrepancies> collectDiscrepanciesPerSubFlow(List<FlowValidationDto> subFlowValidationDetails) { |
There was a problem hiding this comment.
it might be better to use "private static" instead of "static private".
for the sake of common approach
| HashMap<FlowDirection, List<PathDiscrepancyDto>> discrepancy = [:] | ||
| it.value.each { | ||
| verifyValidateLogic(it) | ||
| it.asExpected ?: discrepancy.put(FlowDirection.getByDirection(it.direction.toLowerCase()), it.discrepancies) |
There was a problem hiding this comment.
It might be not the case,
but is it possible that there are at least two discrepancies for the same flowid and the same direction?
what if in the following loop :
it.value.each {
verifyValidateLogic(it)
it.asExpected ?: discrepancy.put(FlowDirection.getByDirection(it.direction.toLowerCase()), it.discrepancies)
}
there will be at least two iteration with the same flowId and the same direction?
There was a problem hiding this comment.
added check for direction per sub-flow (to clarify that we don't have 2 FORWARD validation responses with one discrepancy instead of one FORWARD and two discrepancies) + if we have some invalid direction, it fails during getting FlowDirection
yuliiamir
force-pushed
the
test/complexFlow-validation-check
branch
from
c1dd3da
to
bb04929
Compare
yuliiamir
force-pushed
the
test/complexFlow-validation-check
branch
from
bb04929
to
1fe31f7
Compare
pablomuri
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.