Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/generated evm address withdraw only #741

Merged
merged 22 commits into from
Jan 8, 2024

Conversation

donnyquixotic
Copy link
Contributor

@donnyquixotic donnyquixotic commented Jan 8, 2024

Fixes #740

Test scenarios

  • evm address does not populate on deposit
  • no evm address found message and generate address button
  • on generate address, display address button shown, generate button and not found message hidden
  • on click display address, disclaimer, on confirm displays address, on dismiss nothing
  • on click address copy button, notification confirming copy

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have cleaned up the code in the areas my change touches
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have removed any unnecessary console messages
  • I have included all english text to the translation file and/or created a new issue with the required translations for the currently supported languages
  • I have tested for mobile functionality and responsiveness

@donnyquixotic donnyquixotic self-assigned this Jan 8, 2024
Copy link

netlify bot commented Jan 8, 2024

Deploy Preview for wallet-staging ready!

Name Link
🔨 Latest commit 83353e9
🔍 Latest deploy log https://app.netlify.com/sites/wallet-staging/deploys/659c58d73225a60008cf0e70
😎 Deploy Preview https://deploy-preview-741--wallet-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 8, 2024

Deploy Preview for wallet-develop-mainnet ready!

Name Link
🔨 Latest commit 83353e9
🔍 Latest deploy log https://app.netlify.com/sites/wallet-develop-mainnet/deploys/659c58d74192f9000837e619
😎 Deploy Preview https://deploy-preview-741--wallet-develop-mainnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

…into bugfix/generated-evm-address-withdraw-only
@donnyquixotic donnyquixotic merged commit 69ff14c into develop Jan 8, 2024
9 checks passed
@donnyquixotic donnyquixotic deleted the bugfix/generated-evm-address-withdraw-only branch January 8, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate generated evm address to withdraw only
2 participants