Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#735 | UI tweaks #736

Merged
merged 16 commits into from
Jan 6, 2024
Merged

#735 | UI tweaks #736

merged 16 commits into from
Jan 6, 2024

Conversation

ezra-sg
Copy link
Contributor

@ezra-sg ezra-sg commented Jan 4, 2024

Fixes #735

Fixes #737

Description

This PR contains several small UI fixes. See the issue for details.
This PR also contains updates to how analytics events are handled, see the fathom docs for more info: https://usefathom.com/docs/features/events ; basically, events no longer use event IDs
This PR also moves the UAL login buttons out of a modal and directly onto the login page, as well as fixes an issue where cancelling a cleos login causes an infinite loading state

Test scenarios

UI Tweaks
see issue

Analytics

  • run git fetch --all && git checkout 735-ui-tweaks && yarn dev
  • open src/antelope/chains/evm/telos-evm/index.ts
  • add this before line 164, console.log('tracking event: ' + eventName);
  • go to http://localhost:8081
  • disable any ad blockers
  • open browser dev console
  • click the metamask login option
    • you should see login started event in the console
  • proceed to log in with metamask
    • you should see successful login - metamask and successful login (generic)
  • log out
  • enable safepal and disable metamask and reload the page
  • repeat the metamask steps
    • you should see the corresponding safepal event
  • log out
  • enable brave wallet and disable safepal
  • repeat the metamask steps
    • you should see the corresponding brave wallet event

Login buttons

  • go to http://localhost:8081/?login=zero
    • you should see UAL login options presented the same way as tEVM options
  • try logging in with anchor
    • it should work
  • log out
  • try logging in with cleos
    • it should work

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have cleaned up the code in the areas my change touches
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have removed any unnecessary console messages
  • I have included all english text to the translation file and/or created a new issue with the required translations for the currently supported languages
  • I have tested for mobile functionality and responsiveness
  • I have added appropriate test coverage

Copy link

netlify bot commented Jan 4, 2024

Deploy Preview for wallet-staging ready!

Name Link
🔨 Latest commit 645113e
🔍 Latest deploy log https://app.netlify.com/sites/wallet-staging/deploys/6599b7e93eb1c000087e7ef9
😎 Deploy Preview https://deploy-preview-736--wallet-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 4, 2024

Deploy Preview for wallet-develop-mainnet ready!

Name Link
🔨 Latest commit 645113e
🔍 Latest deploy log https://app.netlify.com/sites/wallet-develop-mainnet/deploys/6599b7ea795225000869e040
😎 Deploy Preview https://deploy-preview-736--wallet-develop-mainnet.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ezra-sg ezra-sg self-assigned this Jan 4, 2024
@ezra-sg ezra-sg marked this pull request as ready for review January 5, 2024 00:33
Copy link
Contributor

@donnyquixotic donnyquixotic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ezra-sg See item 12 in #735. You removed the 'convert' on the balances page but there's another one on the token page. (click on row in balance table on zero to see screenshot)

follow-up issues that don't need to be included in this PR: #737 #738
image

@donnyquixotic donnyquixotic merged commit 753fdf5 into develop Jan 6, 2024
9 checks passed
@donnyquixotic donnyquixotic deleted the 735-ui-tweaks branch January 6, 2024 20:32
@donnyquixotic donnyquixotic mentioned this pull request Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Zero Wallet options to main login toggle menu Wallet UI updates
2 participants