Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#729 | Improve liquid balance display #731

Merged
merged 3 commits into from
Jan 8, 2024

Conversation

ezra-sg
Copy link
Contributor

@ezra-sg ezra-sg commented Jan 3, 2024

Fixes #729

Description

This PR improves how liquid balance is displayed in the Telos Zero UI

Test scenarios

  • go to https://deploy-preview-731--wallet-develop-mainnet.netlify.app/
  • click Telos Zero
  • click View Any Account
  • enter ezrazero.gm
  • click Send
    • you should see a TLOS row with a 0 balance
  • click the empty TLOS row
    • nothing should happen
  • close the send dialog
  • click Disconnect
  • click Telos Zero
  • click View Any Account
  • enter gverntelos21
    • you should see a tooltip next to the total fiat balance at the top
    • the TLOS row in balances should show the correct liquid balance (1 TLOS at the time of writing - you can check current amount on OBE here)
  • click Send
    • the TLOS row should have the correct amount (the liquid amount)
  • click the TLOS row
  • you should be taken to the Send page for TLOS

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have cleaned up the code in the areas my change touches
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have removed any unnecessary console messages
  • I have included all english text to the translation file and/or created a new issue with the required translations for the currently supported languages
  • I have tested for mobile functionality and responsiveness
  • I have added appropriate test coverage

Copy link

netlify bot commented Jan 3, 2024

Deploy Preview for wallet-staging ready!

Name Link
🔨 Latest commit 9a48333
🔍 Latest deploy log https://app.netlify.com/sites/wallet-staging/deploys/659c66ff15ddd300085f4826
😎 Deploy Preview https://deploy-preview-731--wallet-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 3, 2024

Deploy Preview for wallet-develop-mainnet ready!

Name Link
🔨 Latest commit 9a48333
🔍 Latest deploy log https://app.netlify.com/sites/wallet-develop-mainnet/deploys/659c66ffd9cad70008df1f16
😎 Deploy Preview https://deploy-preview-731--wallet-develop-mainnet.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ezra-sg ezra-sg self-assigned this Jan 3, 2024
@ezra-sg ezra-sg marked this pull request as ready for review January 3, 2024 23:43
Copy link
Contributor

@donnyquixotic donnyquixotic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the total TLOS amount (including staked) under the fiat balance at the top of the balances page since that information isn't available in the TLOS balance row anymore?

Viterbo
Viterbo previously approved these changes Jan 8, 2024
Copy link
Collaborator

@Viterbo Viterbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job !

@donnyquixotic donnyquixotic merged commit 5aa7cfe into develop Jan 8, 2024
9 checks passed
@donnyquixotic donnyquixotic deleted the 729-show-liquid-balance branch January 8, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show liquid TLOS balance in native wallet view
3 participants