Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#725 | Fix rows per page dropdown visibility #726

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

ezra-sg
Copy link
Contributor

@ezra-sg ezra-sg commented Jan 2, 2024

Fixes #725

Description

On mobile, the rows per page dropdown on tables is not legible. this is because the dropdown component automatically switches to a modal display on smaller devices, and the modal version was unstyled

Test scenarios

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have cleaned up the code in the areas my change touches
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have removed any unnecessary console messages
  • I have included all english text to the translation file and/or created a new issue with the required translations for the currently supported languages
  • I have tested for mobile functionality and responsiveness
  • I have added appropriate test coverage

Copy link

netlify bot commented Jan 2, 2024

Deploy Preview for wallet-staging ready!

Name Link
🔨 Latest commit 60ac85a
🔍 Latest deploy log https://app.netlify.com/sites/wallet-staging/deploys/6594a249a605900007f417da
😎 Deploy Preview https://deploy-preview-726--wallet-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 2, 2024

Deploy Preview for wallet-develop-mainnet ready!

Name Link
🔨 Latest commit 60ac85a
🔍 Latest deploy log https://app.netlify.com/sites/wallet-develop-mainnet/deploys/6594a24996f8fa000810ce71
😎 Deploy Preview https://deploy-preview-726--wallet-develop-mainnet.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ezra-sg ezra-sg changed the title #725 | Ffix rows per page dropdown visibility #725 | Fix rows per page dropdown visibility Jan 2, 2024
@ezra-sg ezra-sg self-assigned this Jan 2, 2024
@ezra-sg ezra-sg marked this pull request as ready for review January 2, 2024 23:57
Copy link
Collaborator

@Viterbo Viterbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@donnyquixotic donnyquixotic merged commit 676480a into develop Jan 3, 2024
9 checks passed
@donnyquixotic donnyquixotic deleted the 725-rows-per-page-bugfix branch January 3, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Iphone Page Selector Display bug
3 participants