Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling the send button until is ready for transfer #527

Closed
wants to merge 1 commit into from

Conversation

Viterbo
Copy link
Collaborator

@Viterbo Viterbo commented Aug 13, 2023

Fixes #526

Description

Our wallet consists of several ways to authenticate the user and therefore different ways to carry out a transaction. The method that WalletConnect uses is the only one that requires two steps to perform a transaction: the creation of the sendConfig object and the actual execution of the transfer.

However, it happens that if the user tries to execute the transfer before the configuration object is ready, the error described in #526 occurs.

To avoid that, we disable the submit button until we're sure the config object is ready to be used.

Test scenarios

  • log in using WalletConnect using this link
  • fill the fields of the send token form one by one
    • notice that every time you update any field there's a window of time where the send button is disabled
    • you should not be able to send until the config object is set and ready

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have cleaned up the code in the areas my change touches
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have removed any unnecessary console messages
  • I have included all english text to the translation file and/or created a new issue with the required translations for the currently supported languages
  • I have tested for mobile functionality and responsiveness
  • I have added appropriate test coverage

@Viterbo Viterbo self-assigned this Aug 13, 2023
@Viterbo Viterbo linked an issue Aug 13, 2023 that may be closed by this pull request
@netlify
Copy link

netlify bot commented Aug 13, 2023

Deploy Preview for wallet-staging ready!

Name Link
🔨 Latest commit 08baef5
🔍 Latest deploy log https://app.netlify.com/sites/wallet-staging/deploys/64d92b31eaa46a0008684bf8
😎 Deploy Preview https://deploy-preview-527--wallet-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@donnyquixotic donnyquixotic changed the base branch from develop to master August 14, 2023 15:51
@donnyquixotic donnyquixotic changed the base branch from master to develop August 14, 2023 15:57
@donnyquixotic donnyquixotic marked this pull request as draft August 14, 2023 16:06
@donnyquixotic
Copy link
Contributor

resolved via #528 (changed base branch)

@donnyquixotic donnyquixotic deleted the 526-issues-when-sending-erc20-tokens branch August 14, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues when sending ERC20 tokens
2 participants