Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing the old ConnectWalletOptions for the current EVMLoginButtons #516

Merged

Conversation

Viterbo
Copy link
Collaborator

@Viterbo Viterbo commented Aug 8, 2023

Fixes #515

Description

read here

Test scenarios

  • go to this NFT page (make sure you are not logged)
  • try to log in using the side menu button
    • the component popping up should not be the old ConnectWalletOptions but rather the EVMLoginButtons

Screeshot

image

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have cleaned up the code in the areas my change touches
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have removed any unnecessary console messages
  • I have included all english text to the translation file and/or created a new issue with the required translations for the currently supported languages
  • I have tested for mobile functionality and responsiveness
  • I have added appropriate test coverage

@Viterbo Viterbo linked an issue Aug 8, 2023 that may be closed by this pull request
@netlify
Copy link

netlify bot commented Aug 8, 2023

Deploy Preview for wallet-staging ready!

Name Link
🔨 Latest commit f111e61
🔍 Latest deploy log https://app.netlify.com/sites/wallet-staging/deploys/64d235aab28b39000731bbf8
😎 Deploy Preview https://deploy-preview-516--wallet-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Viterbo Viterbo self-assigned this Aug 8, 2023
Copy link
Contributor

@ezra-sg ezra-sg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

@pmjanus pmjanus merged commit 5a2fb7d into develop Aug 13, 2023
5 checks passed
@pmjanus pmjanus deleted the 515-internal-login-is-still-using-the-old-connectwalletoptions branch August 13, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

internal Login is still using the old ConnectWalletOptions
4 participants