Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

quick fixes: ownerLink and new i18n entry #513

Merged
merged 2 commits into from
Aug 10, 2023
Merged

quick fixes: ownerLink and new i18n entry #513

merged 2 commits into from
Aug 10, 2023

Conversation

Viterbo
Copy link
Collaborator

@Viterbo Viterbo commented Aug 7, 2023 •
edited
Loading

Fixes #510, #514

Description

Fixed problems:

  • clicking the owner link incorrectly goes to the token contract page
  • missing localization text for network_switch_success variable

Test scenarios

  • issue 510

    • Go to this NFT page and click oner's link
    • An new tab should open with the correct address being explored

  • issue 514

    • Change network on MetaMask (other than Testnet)
    • try to login with MetaMask
      • you should be prompted to change the network on MetaMask, accept
      • you should be logged and you should get a "Network switched successfully" notification.

@Viterbo Viterbo linked an issue Aug 7, 2023 that may be closed by this pull request
On the NFT detail page, 'owner' link goes to wrong page #510
Closed
@Viterbo Viterbo self-assigned this Aug 7, 2023
@netlify
Copy link

netlify bot commented Aug 7, 2023 •
edited
Loading

✅ Deploy Preview for wallet-staging ready!

Name Link
🔨 Latest commit 438aa25
🔍 Latest deploy log https://app.netlify.com/sites/wallet-staging/deploys/64d1835b8852cf00084aba19
😎 Deploy Preview https://deploy-preview-513--wallet-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Viterbo Viterbo changed the title fixing the coorrect address for ownerLink quick fixes: ownerLink and new i18n entry Aug 7, 2023
@pmjanus pmjanus merged commit ca5d8f7 into develop Aug 10, 2023
5 checks passed
@pmjanus pmjanus deleted the 510-on-the-nft-detail-page-owner-link-goes-to-wrong-page branch August 10, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donnyquixotic donnyquixotic donnyquixotic approved these changes

@ezra-sg ezra-sg ezra-sg approved these changes

@pmjanus pmjanus Awaiting requested review from pmjanus

Assignees

@Viterbo Viterbo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

On the NFT detail page, 'owner' link goes to wrong page
4 participants
@Viterbo @donnyquixotic @ezra-sg @pmjanus