Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login with Social Media #490

Merged
merged 63 commits into from
Jul 28, 2023
Merged

Conversation

Viterbo
Copy link
Collaborator

@Viterbo Viterbo commented Jul 20, 2023

Fixes #463

Description

This PR includes a new button for the Home page (on the EVM side) which provides the users a way to authenticate using social media providers without even having a wallet installed.

Notes

Test scenarios

  • go to this link
  • Press the "Login with Social Media" button
    • A menu with 4 social media authentication providers should appear
  • Choose any provider and press the button
    • a window will pop up to ask you for a pin (If is your first time, it will ask you to repeat the pin)
    • after confirmation
      • the window will load and close automatically
      • you will be logged in with a zero balance account
  • Copy your address, and send to that address some tokens from another account you control
  • After you have some tokens in your balance, go to send page and try to send them (make sure you have some TLOS)
  • When pressing Send button, a window will pop up
  • Enter PIN and confirm
    • the transaction should go with no problems.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have cleaned up the code in the areas my change touches
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have removed any unnecessary console messages
  • I have included all english text to the translation file and/or created a new issue with the required translations for the currently supported languages
  • I have tested for mobile functionality and responsiveness
  • I have added appropriate test coverage

@Viterbo Viterbo linked an issue Jul 20, 2023 that may be closed by this pull request
@Viterbo Viterbo self-assigned this Jul 20, 2023
@netlify
Copy link

netlify bot commented Jul 20, 2023

Deploy Preview for wallet-staging ready!

Name Link
🔨 Latest commit 8ea724d
🔍 Latest deploy log https://app.netlify.com/sites/wallet-staging/deploys/64c407e3bf684200082a9014
😎 Deploy Preview https://deploy-preview-490--wallet-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Viterbo Viterbo changed the base branch from develop to 422-adding-safepal-wallet July 20, 2023 04:35
@Viterbo Viterbo force-pushed the 463-adding-oreid-authenticator branch from 95c6c2a to e801689 Compare July 20, 2023 04:39
@Viterbo Viterbo changed the title Authenticate user with social media Login with Social Media Jul 20, 2023
Copy link
Contributor

@ezra-sg ezra-sg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works very well for me on desktop and mobile, awesome job 💯

@Viterbo Viterbo changed the base branch from 422-adding-safepal-wallet to develop July 24, 2023 20:06
@donnyquixotic donnyquixotic merged commit 39d0fbf into develop Jul 28, 2023
5 checks passed
@donnyquixotic donnyquixotic deleted the 463-adding-oreid-authenticator branch July 28, 2023 18:26
@@ -233,7 +233,7 @@ export class OreIdAuth extends EVMAuthenticator {
const transaction = await oreId.createTransaction({
transaction: transactionBody,
chainAccount: from,
chainNetwork: ChainNetwork.TelosEvmTest,
chainNetwork: this.getChainNetwork(useChainStore().getChain(this.label).settings.getNetwork()),
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice !!! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EVM Wallet - Add Telos Cloud Wallet (OreId) using WalletConnect.
3 participants