Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#440 | Wrap page header #460

Merged
merged 7 commits into from
Jul 12, 2023
Merged

#440 | Wrap page header #460

merged 7 commits into from
Jul 12, 2023

Conversation

ezra-sg
Copy link
Contributor

@ezra-sg ezra-sg commented Jul 5, 2023

Fixes #440

Description

This PR adds the header section of the Wrap page. It also fixes an issue with the prettyPrintCurrency util

Test scenarios

  • this PR must be tested locally because feature branches do not get netlify builds
  • run git fetch --all && git checkout 440-wrap-page-header && yarn dev
  • go to http://localhost:8081
  • log in
  • go to Wrap page from navbar
    • the total balances and fiat value should be correct (you can compare to the balances page for this)
    • the amounts in the cards should add up to the total at the top (may be rounded slightly)

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have cleaned up the code in the areas my change touches
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have removed any unnecessary console messages
  • I have included all english text to the translation file and/or created a new issue with the required translations for the currently supported languages
  • I have tested for mobile functionality and responsiveness
  • I have added appropriate test coverage

@ezra-sg ezra-sg marked this pull request as ready for review July 5, 2023 20:45
@ezra-sg ezra-sg changed the base branch from develop to epic-wrap July 5, 2023 20:51
@ezra-sg ezra-sg marked this pull request as draft July 5, 2023 20:54
Copy link
Collaborator

@Viterbo Viterbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@ezra-sg ezra-sg marked this pull request as ready for review July 11, 2023 23:23
@telosnetwork telosnetwork deleted a comment from netlify bot Jul 11, 2023
@donnyquixotic donnyquixotic merged commit dce1413 into epic-wrap Jul 12, 2023
1 check passed
@donnyquixotic donnyquixotic deleted the 440-wrap-page-header branch July 12, 2023 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrap/Unwrap TLOS - Page header
3 participants