-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for priorityClassName in affinityAssistantPodTemplate #8286
Conversation
Skipping CI for Draft Pull Request. |
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
03c8823
to
bc65608
Compare
The following is the coverage report on the affected files.
|
bc65608
to
4294f7e
Compare
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
/test pull-tekton-pipeline-integration-tests |
4294f7e
to
a0027a3
Compare
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
This will add the support for specifying priorityClassName for affinity assistant pods. It will be possible to specify default value of priorityClassName in defaultAffinityAssistant pod template. Also the priorityClassName value specified in pipelinerun/taskrun will overwrite the default value of priorityClassName and same value will be used for both affinity assistant pods and tasrun pods. This will help to specify same priorityClassName for affinity assistant pods and task run pods, so all get scheduled with same priority Part of tektoncd#7779 /kind feature
a0027a3
to
0ddeaf5
Compare
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @piyush-garg
/lgtm
This will add the support for specifying priorityClassName
for affinity assistant pods. It will be possible to specify
default value of priorityClassName in defaultAffinityAssistant
pod template. Also the priorityClassName value specified in
pipelinerun/taskrun will overwrite the default value of
priorityClassName and same value will be used for both
affinity assistant pods and tasrun pods.
This will help to specify same priorityClassName for
affinity assistant pods and task run pods, so all get
scheduled with same priority
Part of #7779
/kind feature
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes