-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix ValidateStepResultsVariables to validate stepResults only #8264
base: main
Are you sure you want to change the base?
Conversation
a7cd2bb
to
8e0fa48
Compare
/kind bug |
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
8e0fa48
to
0c6cd04
Compare
0c6cd04
to
18dee1a
Compare
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
18dee1a
to
7c5e691
Compare
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
e078cdd
to
98e4c6f
Compare
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
98e4c6f
to
f1fc5c5
Compare
The following is the coverage report on the affected files.
|
The following is the coverage report on the affected files.
|
@vdemeester
|
/test pull-tekton-pipeline-beta-integration-tests |
1 similar comment
/test pull-tekton-pipeline-beta-integration-tests |
/test pull-tekton-pipeline-go-coverage-df |
@afrittoli: The specified target(s) for
The following commands are available to trigger optional jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The following is the coverage report on the affected files.
|
@jkhelil It would be great if this is covered as part of e2e if possible to add |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Changes
fixes #8255
There is a mixture of validating step result and task result in both ValidateStepResultsVariables
ValidateStepResultsVariables should use step results set of name to only validate StepResults. TaskResults are validated via the function ValidateTaskResultsVariables
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes