Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] worker wrangler #52

Merged
38 commits merged into from
Jan 6, 2022
Merged

[WIP] worker wrangler #52

38 commits merged into from
Jan 6, 2022

Conversation

ghost
Copy link

@ghost ghost commented Dec 20, 2021 •
edited by aldy505
Loading

Closes #50

@ghost ghost added scope: backend Regarding the backend side DO NOT MERGE!!!!!! labels Dec 20, 2021
aldy505
aldy505 reviewed Dec 20, 2021
View reviewed changes
wranggler/main.go Outdated Show resolved Hide resolved
@aldy505 aldy505 changed the title feat: [WIP] worker wranggler [WIP] worker wrangler Dec 20, 2021
aldy505
aldy505 reviewed Dec 21, 2021
View reviewed changes
wranggler/Dockerfile Outdated Show resolved Hide resolved
wranggler/Dockerfile Outdated Show resolved Hide resolved
@aldy505 aldy505 assigned ghost Dec 23, 2021
aldy505
aldy505 reviewed Dec 24, 2021
View reviewed changes
wranggler/Dockerfile Outdated Show resolved Hide resolved
wranggler/Dockerfile Show resolved Hide resolved
wranggler/file.go
for k := 0; k < structValue.NumField(); k++ {
currentValue := structValue.Field(k)

switch currentValue.Interface().(type) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might implement a float64 type later

aldy505
aldy505 reviewed Dec 27, 2021
View reviewed changes
wranggler/funfact.go Outdated Show resolved Hide resolved
wranggler/funfact.go Outdated Show resolved Hide resolved
@aldy505
Copy link
Member

aldy505 commented Dec 28, 2021

nanti pagi atau besok malem bakal bikin PR soal ini + dummy data

@ghost
Copy link
Author

ghost commented Dec 29, 2021

nanti pagi atau besok malem bakal bikin PR soal ini + dummy data

UwU

@aldy505
Copy link
Member

aldy505 commented Dec 30, 2021

btw member id diganti jadi uuid, jadi coba pake github.com/google/uuid, jangan pake uuid.MustParse, pake yang uuid.Parse aja, terus type si Member.ID ini jadiin uuid.UUID

@ghost
Copy link
Author

ghost commented Dec 30, 2021

btw member id diganti jadi uuid, jadi coba pake github.com/google/uuid, jangan pake uuid.MustParse, pake yang uuid.Parse aja, terus type si Member.ID ini jadiin uuid.UUID

kenapa jadi uuid.UUID ?

@aldy505
Copy link
Member

aldy505 commented Dec 30, 2021

btw member id diganti jadi uuid, jadi coba pake github.com/google/uuid, jangan pake uuid.MustParse, pake yang uuid.Parse aja, terus type si Member.ID ini jadiin uuid.UUID

kenapa jadi uuid.UUID ?

jawaban di telegram ya

@ghost ghost requested a review from aldy505 January 6, 2022 12:49
aldy505
aldy505 requested changes Jan 6, 2022
View reviewed changes
wranggler/funfact.go Show resolved Hide resolved
wranggler/funfact.go Outdated Show resolved Hide resolved
wranggler/file_test.go Outdated Show resolved Hide resolved
wranggler/file_test.go Outdated Show resolved Hide resolved
@aldy505
Copy link
Member

aldy505 commented Jan 6, 2022 •
edited
Loading

PR ini udah kebanyakan commit, fix yang itu aja abis itu merge to master. kita move implement bits and pieces nya along the way ya. @artileda

@ghost ghost merged commit c8921e8 into master Jan 6, 2022
@aldy505 aldy505 deleted the worker branch January 6, 2022 14:36
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
DO NOT MERGE!!!!!! scope: backend Regarding the backend side WORK IN PROGRESS!!!!!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Worker app to render data
1 participant
@aldy505