Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #64 and #78 #79

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix for #64 and #78 #79

wants to merge 2 commits into from

Conversation

SuperSimon81
Copy link

Added extensions.zotero.night.enabled - true to config. The fix is described in [BUG] Plugin seems to not save preferences correctly #64 and further referenced in [BUG] Dark filter not working in pdf reader #78

 Added extensions.zotero.night.enabled - true to config. The fix is described in [BUG] Plugin seems to not save preferences correctly tefkah#64 and further referenced in [BUG] Dark filter not working in pdf reader tefkah#78
Small bugfix for dark filter while reading pdf
@tefkah
Copy link
Owner

tefkah commented Nov 2, 2022

Hmmm I feel like this PR shouldn't do anything right? Does this work for you?

@SuperSimon81
Copy link
Author

Adding 'extensions.zotero.night.enabled', 'true' to the zotero preferences works for Mac

I found the config.js file containing the other preferences and added and line there

@tefkah
Copy link
Owner

tefkah commented Nov 3, 2022

no but all the lines are commented out, they shouldn't do anything. The file as it is currently is superfluous, I commented out those lines because they sometimes caused problems. I haven't tested enabling them in a while tho, might fix the problems.

I feel like the success you had is probably due to actually toggling the setting at some point, it's just not possible that this PR actually changes any behavior, as the commented out lines shouldn't even appear in the final compiled code.

@SuperSimon81
Copy link
Author

I understand. The success I had was due to manually setting extensions.zotero.night.enabled true in the settings. I was wrong to assume that config.js was where you set them, and didn´t notice comments.

Where do you set the settings then? Adding extensions.zotero.night.enabled true there would solve the bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants