Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: night for standalone reader window #10

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

windingwind
Copy link

test new feature via:

  • press shift & click to open the item;
  • right-click on reader tab & select move to new window

image

@windingwind
Copy link
Author

Hi, this PR has been open for a while. It is ready to be merged into the main branch at any time.

The new window detection is a little tricky because Zotero right now doesn't trigger any notification for a new window open/close. I just check the reader list status and see if there are new standalone readers.

This part of the code has been stable and applied in my repo https://github.com/windingwind/zotero-pdf-translate/ for some time and it works well.

@tefkah
Copy link
Owner

tefkah commented May 11, 2022

Hey! I'll try to merge this today, there isn't really any reason for me waiting but need to test it etc. I also meant to respond to your #8, which I'll do there, but in short I was thinking: would you be interested in comaintaining Night? You seem to have a lot more experience making Zotero extensions than me and would love to work together!

@windingwind
Copy link
Author

Hi, I'm always willing to do something for this excellent plugin!

The only concern is the lack of time. Currently, I have 3 Zotero plugin repo to maintain(nearly all on my own). The Knowledge4Zotero is just released and a frequent bug fix & feature update in the following months is predictable.

I'll see if there is anything I can do. Or, just assign some tasks to me.

One more thing: I saw your excellent workorg-roam-ui of yours!
The Knowledge4Zotero plugin mentioned above aims to extend the Zotero built-in note editor as a quick note tool while reading papers by linking annotations and notes in one place with an easy export. The mind map view of notes is integrated, though a very naive version. Some researchers have reported it very useful with review writing & historical excerpts.

It is partly very like the org-roam-ui! I'm wondering if there is an easy way to integrate it into Zotero?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants