Skip to content

Commit

Permalink
Merge pull request #1543 from partik-mis/1542-fix
Browse files Browse the repository at this point in the history
Fix for #1542.
  • Loading branch information
dhensby authored Sep 5, 2023
2 parents 0c9ce86 + ff05cce commit 53fc9ea
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 2 deletions.
18 changes: 17 additions & 1 deletion CHANGELOG.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,20 @@
v9.1.3 (2023-??-??)
v9.3.1 (2023-09-05)
-------------------
[fix] Fix bug with msnodesqlv8 connection strings ((#1525)[https://github.com/tediousjs/node-mssql/pull/1525])

v9.3.0 (2023-09-04)
-------------------
[new] Add AAD connection support to connection strings ((#1461)[https://github.com/tediousjs/node-mssql/pull/1461])

v9.2.1 (2023-09-05)
-------------------
[fix] Fix bug with msnodesqlv8 connection strings ((#1525)[https://github.com/tediousjs/node-mssql/pull/1525])

v9.2.0 (2023-08-28)
-------------------
[new] Use @tediousjs/connection-string library to build msnodesqlv8 connection strings ((#1525)[https://github.com/tediousjs/node-mssql/pull/1525])

v9.1.3 (2023-08-08)
-------------------
[fix] Escape values that are added to the msnodesqlv8 connection string that we construct ((#1479)[https://github.com/tediousjs/node-mssql/pull/1479])

Expand Down
2 changes: 1 addition & 1 deletion lib/msnodesqlv8/connection-pool.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ class ConnectionPool extends BaseConnectionPool {
if (!this.config.connectionString) {
cfg.conn_str = buildConnectionString({
Driver: CONNECTION_DRIVER,
Server: this.config.options.instanceName ? `${this.config.server}\\${this.config.instanceName}` : `${this.config.server},${this.config.port}`,
Server: this.config.options.instanceName ? `${this.config.server}\\${this.config.options.instanceName}` : `${this.config.server},${this.config.port}`,
Database: this.config.database,
Uid: this.config.user,
Pwd: this.config.password,
Expand Down

0 comments on commit 53fc9ea

Please sign in to comment.